Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - fix @TransientReference destruction #27914

Merged
merged 1 commit into from
Sep 19, 2022
Merged

ArC - fix @TransientReference destruction #27914

merged 1 commit into from
Sep 19, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 14, 2022

@mkouba mkouba requested review from Ladicek and manovotn September 14, 2022 07:28
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 14, 2022
@mkouba mkouba mentioned this pull request Sep 14, 2022
Closed
Ladicek
Ladicek approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not terribly familiar with @TransientReference, so a second pair of eyes would be good :-) @manovotn could you please take a look? Thanks!

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
ArC - fix @TransientReference destruction
bcffcb4 
- remove the transient dependent instance from the parent creational
context when the invocation completes
- fixes quarkusio#27906
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2022

Failing Jobs - Building bcffcb4

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc-code-flow

📦 integration-tests/oidc-code-flow

✖ io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh line 519 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/tenant-autorefresh
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:461)

manovotn
manovotn approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugged it a little to understand what's going on and it LGTM!

@mkouba mkouba merged commit f057ca8 into quarkusio:main Sep 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 19, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.12.3.Final Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix triage/flaky-test
Projects
None yet
Milestone
2.12.3.Final
Development

Successfully merging this pull request may close these issues.

@TransientReference results in @Dispose method being called multiple times
4 participants
@mkouba @Ladicek @manovotn @gsmet