-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Kubernetes model for native registration more complete #27563
Conversation
cc @manusa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ LGTM
The Fluent classes are not covered by these changes. They are part of the XXXBuilder chain, so I assume they'll be automatically gathered just by registering the builder. |
That should be the case, yeah |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a minor observation about the deprecated method
...loyment/src/main/java/io/quarkus/jackson/deployment/IgnoreJsonDeserializeClassBuildItem.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
...loyment/src/main/java/io/quarkus/jackson/deployment/IgnoreJsonDeserializeClassBuildItem.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building 59a8918
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
⚙️ JVM Tests - JDK 18 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
Fixes: #27469
BTW, this PR increases the native binary size a little (3MB on the integration test we have)