Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HelloRouterTest more robust #27368

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 18, 2022

No description provided.

@gsmet gsmet requested a review from radcortez August 18, 2022 16:33
@gsmet gsmet merged commit 52379a5 into quarkusio:main Aug 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 23, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.11.3.Final Aug 23, 2022
@radcortez
Copy link
Member

The problem here is that the spans should follow the order set in the test. I couldn't determine why they were coming out of order occasionally. With #27230 I added some additional log to try to debug further. Let me check some of the failures.

@radcortez
Copy link
Member

For some reason, the CONSUMER span is getting the same startEpochNanos as the SERVER span, which doesn't make much sense (and then it messes the expected assert order):

[
  {
    "attributes": {
      "messaging.destination": "bus",
      "messaging.system": "vert.x",
      "messaging.protocol_version": "4.0",
      "messaging.destination_kind": "topic"
    },
    "totalAttributeCount": 4,
    "totalRecordedEvents": 0,
    "status": {
      "statusCode": "UNSET",
      "description": ""
    },
    "name": "bus send",
    "endEpochNanos": 1661247385273767000,
    "resource": {
      "schemaUrl": null,
      "attributes": {
        "empty": false
      }
    },
    "startEpochNanos": 1661247385270408100,
    "spanContext": {
      "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
      "spanId": "4261620aa8f2e70d",
      "traceFlags": {
        "sampled": true
      },
      "traceState": {
        "empty": true
      },
      "remote": false,
      "valid": true,
      "sampled": true,
      "spanIdBytes": "QmFiCqjy5w0",
      "traceIdBytes": "EBbQwn74eL5ojB9LX3A7xw"
    },
    "kind": "PRODUCER",
    "events": [
    ],
    "links": [
    ],
    "instrumentationScopeInfo": {
      "name": "io.quarkus.opentelemetry",
      "version": null,
      "schemaUrl": null
    },
    "parentSpanContext": {
      "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
      "spanId": "9bb8e1a45fdf250f",
      "traceFlags": {
        "sampled": true
      },
      "traceState": {
        "empty": true
      },
      "remote": false,
      "valid": true,
      "sampled": true,
      "spanIdBytes": "m7jhpF_fJQ8",
      "traceIdBytes": "EBbQwn74eL5ojB9LX3A7xw"
    },
    "instrumentationLibraryInfo": {
      "name": "io.quarkus.opentelemetry",
      "version": null,
      "schemaUrl": null
    },
    "totalRecordedLinks": 0,
    "parentSpanId": "9bb8e1a45fdf250f",
    "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
    "spanId": "4261620aa8f2e70d"
  },
  {
    "attributes": {
      "http.method": "GET",
      "http.client_ip": "127.0.0.1",
      "http.status_code": 200,
      "http.scheme": "http",
      "http.host": "localhost:8081",
      "http.response_content_length": 5,
      "http.target": "/bus",
      "http.route": "/bus",
      "http.user_agent": "Apache-HttpClient/4.5.13 (Java/11.0.16)",
      "http.flavor": "1.1"
    },
    "totalAttributeCount": 11,
    "totalRecordedEvents": 0,
    "status": {
      "statusCode": "UNSET",
      "description": ""
    },
    "name": "/bus",
    "endEpochNanos": 1661247385274084200,
    "resource": {
      "schemaUrl": null,
      "attributes": {
        "empty": false
      }
    },
    "startEpochNanos": 1661247385267964600,
    "spanContext": {
      "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
      "spanId": "9bb8e1a45fdf250f",
      "traceFlags": {
        "sampled": true
      },
      "traceState": {
        "empty": true
      },
      "remote": false,
      "valid": true,
      "sampled": true,
      "spanIdBytes": "m7jhpF_fJQ8",
      "traceIdBytes": "EBbQwn74eL5ojB9LX3A7xw"
    },
    "kind": "SERVER",
    "events": [
    ],
    "links": [
    ],
    "instrumentationScopeInfo": {
      "name": "io.quarkus.opentelemetry",
      "version": null,
      "schemaUrl": null
    },
    "parentSpanContext": {
      "traceId": "00000000000000000000000000000000",
      "spanId": "0000000000000000",
      "traceFlags": {
        "sampled": false
      },
      "traceState": {
        "empty": true
      },
      "remote": false,
      "valid": false,
      "sampled": false,
      "spanIdBytes": "AAAAAAAAAAA",
      "traceIdBytes": "AAAAAAAAAAAAAAAAAAAAAA"
    },
    "instrumentationLibraryInfo": {
      "name": "io.quarkus.opentelemetry",
      "version": null,
      "schemaUrl": null
    },
    "totalRecordedLinks": 0,
    "parentSpanId": "0000000000000000",
    "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
    "spanId": "9bb8e1a45fdf250f"
  },
  {
    "attributes": {
      "messaging.operation": "receive",
      "messaging.destination": "bus",
      "messaging.system": "vert.x",
      "messaging.protocol_version": "4.0",
      "messaging.destination_kind": "topic"
    },
    "totalAttributeCount": 5,
    "totalRecordedEvents": 0,
    "status": {
      "statusCode": "UNSET",
      "description": ""
    },
    "name": "bus receive",
    "endEpochNanos": 1661247385268608500,
    "resource": {
      "schemaUrl": null,
      "attributes": {
        "empty": false
      }
    },
    "startEpochNanos": 1661247385267964600,
    "spanContext": {
      "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
      "spanId": "5d439f8725eb9834",
      "traceFlags": {
        "sampled": true
      },
      "traceState": {
        "empty": true
      },
      "remote": false,
      "valid": true,
      "sampled": true,
      "spanIdBytes": "XUOfhyXrmDQ",
      "traceIdBytes": "EBbQwn74eL5ojB9LX3A7xw"
    },
    "kind": "CONSUMER",
    "events": [
    ],
    "links": [
    ],
    "instrumentationScopeInfo": {
      "name": "io.quarkus.opentelemetry",
      "version": null,
      "schemaUrl": null
    },
    "parentSpanContext": {
      "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
      "spanId": "4261620aa8f2e70d",
      "traceFlags": {
        "sampled": true
      },
      "traceState": {
        "empty": true
      },
      "remote": true,
      "valid": true,
      "sampled": true,
      "spanIdBytes": "QmFiCqjy5w0",
      "traceIdBytes": "EBbQwn74eL5ojB9LX3A7xw"
    },
    "instrumentationLibraryInfo": {
      "name": "io.quarkus.opentelemetry",
      "version": null,
      "schemaUrl": null
    },
    "totalRecordedLinks": 0,
    "parentSpanId": "4261620aa8f2e70d",
    "traceId": "1016d0c27ef878be688c1f4b5f703bc7",
    "spanId": "5d439f8725eb9834"
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants