Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when multiple container image extensions are present #26926

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 26, 2022

The error message now looks something like:

[ERROR] [error]: Build step io.quarkus.container.image.deployment.ContainerImageProcessor#publishImageInfo threw an exception: java.lang.IllegalStateException: quarkus-container-image-jib and quarkus-container-image-docker were detected, at most one container-image extension can be present.
[ERROR] Either remove the unneeded ones, or select one by setting any of the following configuration properties: 'quarkus.container-image.builder=docker','quarkus.container-image.builder=jib'

where it used to be:

[ERROR] [error]: Build step io.quarkus.container.image.deployment.ContainerImageProcessor#publishImageInfo threw an exception: java.lang.IllegalStateException: quarkus-container-image-jib and quarkus-container-image-docker were detected, at most one container-image extension can be present.
[ERROR] Either remove the unneeded ones, or select one by adding the property 'quarkus.container-image.builder=<extension name (without the container-image- prefix)>' in application.properties or as a system property.

Closes: #26589

@geoand geoand requested a review from iocanel July 26, 2022 09:39
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 26, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should count at least 2 words to describe the change properly
  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@geoand geoand changed the title #26589 Improve error message when multiple container image extensions are present Jul 26, 2022
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 26, 2022
@geoand geoand merged commit 0075ba0 into quarkusio:main Jul 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 26, 2022
@geoand geoand deleted the #26589 branch July 26, 2022 10:54
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 26, 2022
@gsmet gsmet modified the milestones: 2.12 - main, 2.11.1.Final Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openshift and Docker Extension Dependencies not activating from an activated Maven Profile
3 participants