-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the quarkus-kotlin extension status to stable #26846
Conversation
@@ -5,7 +5,6 @@ https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc | |||
//// | |||
= Using Kotlin | |||
|
|||
:extension-status: preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove include::{includes}/extension-status.adoc[]
a few lines below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gastaldi we always only included the note in non-stable extensions so I want us to stay consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also would be nice to have someplace where there's docs for the caveats mentioned in the the dev thread for Kotlin support. |
This comment has been minimized.
This comment has been minimized.
42d9869
to
9b7f5d0
Compare
This comment has been minimized.
This comment has been minimized.
we should probably also "promote" the other kotlin modules.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably also "promote" the other kotlin modules.
- mongodb-panache-kotlin is listed as stable already
- hibernate-orm-panache-kotlin is still experimental.
- quarkus-resteasy-reactive-kotlin doesn't have anything in it's quarkus-extension.yaml at all. I don't know what that means.
- resteasy-reactive-kotlin-serialization is listed as experimental
Just to clarify, @evanchooly you would like to make them all
|
9b7f5d0
to
145f46f
Compare
Changed the statuses of |
@n1hility I think you should probably be involved in this discussion too. |
@evanchooly do you expect any major changes to the extensions in this list? I just want to make sure that we are at a stage where we feel good about the APIs and they are not under flux. |
I don't. All the panache bits are driven by common interfaces and the others don't have much or any user facing interfaces. |
Ok then I am +1 sans any extensions we have doubts about. |
@evanchooly I let you have a look to the latest changes and merge if ready. |
Following the discussion https://groups.google.com/g/quarkus-dev/c/Yz3BriSfsf4/m/HVFLNfPtCAAJ?utm_medium=email&utm_source=footer
It doesn't seem like there are major issues to fix to earn the
stable
status forquarkus-kotlin
. Any objections?