WIP - switch images to multi-arches images #26813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/devtools
gsmet
reviewed
Jul 19, 2022
| @@ -29,7 +29,7 @@ public class JibConfig { | |||
| * "registry.access.redhat.com/ubi8/ubi-minimal" which is a bigger base image, but provide more built-in utilities | |||
| * such as the microdnf package manager. | |||
| */ | |||
| @ConfigItem(defaultValue = "quay.io/quarkus/quarkus-micro-image:1.0") | |||
| @ConfigItem(defaultValue = "quay.io/cescoffi/quarkus-micro:2.0") | |||
There was a problem hiding this comment.
Should the -image really be removed here? You keep it everywhere else?
There was a problem hiding this comment.
No no, my mistake, I will fix the name.
Be aware that it's just tests, far from being ready. I test images on both architectures.
I may have to introduce a platform attribute in Quarkus to ask ARM machine to build AMD images (and this is not going to be fun as I would need to change the generated docker file, jib ....)
|
Closing in favor of #27997. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.