OpenTelemetry: NPE in HttpInstrumenterVertxTracer.RouteGetter when request got cancelled

[tmihalac]

Fixes #26764

Signed-off-by: Theodor Mihalache [email protected]

[quarkus-bot]

/cc @radcortez

[radcortez]

There are other places we call response.get*, so maybe we need to address those.

[gsmet]

@radcortez but will you call the methods of ServerAttributesExtractor if you don't have a response? Because AFAICS, the others are in the extractor.

[radcortez]

Even when we don't have a response, we need to call instrumenter.end(...) to finish the span. Inside, OTel will call the extractor to fill in the tags in the span, also calling the ones that require a Response. We don't have control over this.

[gsmet]

@tmihalac can you adjust and also be null safe for the methods in ServerAttributesExtractor that are manipulating response? From what I can see, you can return null if the response is null.

[tmihalac]

@tmihalac can you adjust and also be null safe for the methods in ServerAttributesExtractor that are manipulating response? From what I can see, you can return null if the response is null.

So all I need to do is to be null safe with the response in ServerAttributesExtractor ?

[gsmet]

Apart from my small comment, I think it makes sense.

But I will let @radcortez have the final say.

[gsmet]

For the formatting issues, I recommend you have a look at: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style .
And also run the formatter before pushing if you have doubts. But frankly, you should always build before pushing to check things at least compile.

Also, time for you to learn how to squash your commits yourself :).

What I personally do is:

git rebase -i <hash of the commit before my first change>

This will open an editor.
I keep p for the first commit and put f for the commit I want to squash. Then close the editor and Git should squash the commits. You can then force push to your branch.

Note: be careful when doing that as you rewrite the history.

[radcortez]

Thank you!