Strip debug information from the native executable unconditionally #26681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR quarkusio#13963 mistakenly stopped stripping debug information from the native executable when debug info generation is enabled resulting in both the native executable and the corresponding `.debug` file containing the debug information. Which also results in the native executable being larger when `-Dquarkus.native.debug.enabled` is used: ``` $ du -hs quarkus-integration-test-main-999-SNAPSHOT-runner-nodebug 108M quarkus-integration-test-main-999-SNAPSHOT-runner-nodebug $ du -hs quarkus-integration-test-main-999-SNAPSHOT-runner-debug 182M quarkus-integration-test-main-999-SNAPSHOT-runner-debug $ du -hs quarkus-integration-test-main-999-SNAPSHOT-runner-debug.debug 75M quarkus-integration-test-main-999-SNAPSHOT-runner-debug.debug ``` Inspecting `quarkus-integration-test-main-999-SNAPSHOT-runner-debug` and `quarkus-integration-test-main-999-SNAPSHOT-runner-debug` with `readelf --debug-dump=info` we observe that both files are containing debug information while only the latter should contain them.
gsmet
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13963 mistakenly stopped stripping debug information from the native
executable when debug info generation is enabled resulting in both the
native executable and the corresponding
.debugfile containing thedebug information. Which also results in the native executable being
larger when
-Dquarkus.native.debug.enabledis used:Inspecting
quarkus-integration-test-main-999-SNAPSHOT-runner-debugandquarkus-integration-test-main-999-SNAPSHOT-runner-debugwithreadelf --debug-dump=infowe observe that both files are containingdebug information while only the latter should contain them.