-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Quarkiverse template build and release #26575
Conversation
@FroMage this is the PR to merge if your Renarde release passes. |
That seems to be specific to the Renarde build and not necessary for other extensions, so I'm +0 for this. |
@gastaldi no this is for all Quarkiverse extensions with a codestart |
Ah I see. Are we already generating a codestart project next to the extension? |
wdym? |
You said this change is for Quarkiverse extensions with a codestart, I wonder if |
Not yet, but we should make this available as an option for sure! |
@@ -47,7 +47,7 @@ jobs: | |||
- name: Maven release ${{steps.metadata.outputs.current-version}} | |||
run: | | |||
git checkout -b release | |||
mvn -B release:prepare -Prelease -DreleaseVersion=${{steps.metadata.outputs.current-version}} -DdevelopmentVersion=${{steps.metadata.outputs.next-version}} | |||
mvn -B release:prepare -Prelease -DpreparationGoals="clean install" -DreleaseVersion=${{steps.metadata.outputs.current-version}} -DdevelopmentVersion=${{steps.metadata.outputs.next-version}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the project's pom.xml instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be possible but is it worth the effort? Do we release in some other place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's wait for the Quarkiverse parent release and I'll update this PR (parent version + build) then 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ia3andy could you rebase this PR with the latest parent? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't released quarkiverse-parent yet, I'm waiting for the next JReleaser release to do it all in one batch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW JReleaser 1.2.0 comes out by the end of August. We've adopted a 2 month release cadence for stable releases to help with planning jreleaser/jreleaser#873
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased, but I am not sure if we should merge this or not... Maybe it's better to have this until we have the actual fix ready?
This comment has been minimized.
This comment has been minimized.
1889be9
to
413ef0e
Compare
Using only
verify
in mvn build and release won't let codestart tests pass.Reason is that the tests are using the actual artifacts which should be installed in the local repo with
install
.Note:
install
is the goal just afterverify