Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix podman DNS issue #26422

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Attempt to fix podman DNS issue #26422

merged 1 commit into from
Jun 29, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 29, 2022

As found by @holly-cummins, podman's internal DNS
is case-sensitive. This seems to be causing issues
for some our dev-services being run on podman.
This changes ensures that the hostname is always lowercase
thus circumventing the problem.

See this for a complete discussion

@holly-cummins
Copy link
Contributor

I confirm this fixes the Mongo test cases in quarkus-integration-test-container-image-invoker, and so is a partial resolution of #25230. More generally, I think this is a sensible change. DNS is supposed to be case insensitive, so using mixed case names gains nothing and exposes us to bugs.

(Some libraries, like Mongo, do their own toLowerCase() on hostnames and so we're better off beating them to it and `toLowerCase()-ing first so hostnames are consistent throughout.)

@geoand
Copy link
Contributor Author

geoand commented Jun 29, 2022

Thanks a lot of the confirmation and more importantly for identifying the root cause of the problem @holly-cummins!
This exercise was super useful, although I am not sure it was not fun for you...

@geoand geoand marked this pull request as ready for review June 29, 2022 08:26
@geoand geoand requested a review from cescoffier June 29, 2022 08:26
As found by @holly-cummins, podman's internal DNS
is case-sensitive. This seems to be causing issues
for some our dev-services being run on podman.
This changes ensures that the hostname is always lowercase
thus circumventing the problem.

See https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/DNS.20woes.3A.20Podman.20.2B.20Mongo.20.2B.20Dev.20services.20.2FTestcontainers.20-.2E.2E.2E/near/287736870
for a complete discussion
@geoand geoand merged commit a51cc2e into quarkusio:main Jun 29, 2022
@geoand geoand deleted the podman-dns branch June 29, 2022 12:16
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 29, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 29, 2022
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.2.Final Jul 4, 2022
@gsmet gsmet modified the milestones: 2.10.2.Final, 2.7.7.Final Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants