Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always create a duplicated context in OpenTelemetry when executing client requests #26332

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Always create a duplicated context in OpenTelemetry when executing client requests #26332

merged 1 commit into from
Jul 4, 2022

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jun 23, 2022 •
edited
Loading

@radcortez radcortez requested a review from brunobat June 24, 2022 17:57
@gsmet
Copy link
Member

gsmet commented Jun 27, 2022

@brunobat could you have a look at this one in priority? I would like to include it in the upcoming 2.10.1.Final.

@radcortez radcortez marked this pull request as draft June 27, 2022 22:58
@radcortez radcortez marked this pull request as ready for review June 28, 2022 11:32
@radcortez radcortez requested a review from cescoffier June 28, 2022 11:32
@radcortez radcortez mentioned this pull request Jun 28, 2022
Closed
@radcortez radcortez marked this pull request as draft June 28, 2022 19:01
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 28, 2022
@radcortez radcortez force-pushed the fix-25336 branch 2 times, most recently from debf3e2 to bae4932 Compare June 29, 2022 09:33
@radcortez radcortez marked this pull request as ready for review June 29, 2022 09:33
@radcortez radcortez requested a review from cescoffier June 29, 2022 09:34
@quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a comment, the rest looks good.

brunobat
brunobat approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Thanks @radcortez

@gsmet gsmet merged commit 64f47d0 into quarkusio:main Jul 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jul 4, 2022
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.2.Final Jul 4, 2022
This was referenced Jul 20, 2022
Closed
Closed
@radcortez radcortez deleted the fix-25336 branch December 16, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/tracing kind/bugfix
Projects
None yet
Milestone
2.10.2.Final
Development

Successfully merging this pull request may close these issues.

OpenTelemetry with reactive rest client not working properly OpenTelemetry Vertx issue - divided traces
4 participants
@radcortez @gsmet @cescoffier @brunobat