Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus Builder - introduce build metrics #25786

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Quarkus Builder - introduce build metrics #25786

merged 1 commit into from
Jun 21, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 25, 2022

  • dump the metrics to a JSON file in the build output:
    A. always in the dev mode
    B. when a system property is set: -Dquarkus.debug.dump-build-metrics=true
  • add the list of the build steps to the Dev UI

@mkouba
Copy link
Contributor Author

mkouba commented May 25, 2022

This is the first PR that integrates some high-level build metrics in quarkus, inspired by the https://github.com/mkouba/quarkus-build-report. Other PRs will follow (if accepted ;-).

@mkouba
Copy link
Contributor Author

mkouba commented May 25, 2022

CC @gsmet @FroMage @maxandersen @geoand @franz1981

@geoand
Copy link
Contributor

geoand commented May 25, 2022

👍🏼

@quarkus-bot

This comment has been minimized.

Sign in to view
@maxandersen
Copy link
Member

Crazy idea..why not push this in as custom jfr metrics ?

@mkouba
Copy link
Contributor Author

mkouba commented May 26, 2022

Crazy idea..why not push this in as custom jfr metrics ?

@franz1981 has a plan for JFR ;-)

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Jun 14, 2022

This PR should be ready for review now.

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba requested review from geoand, gsmet and dmlloyd June 14, 2022 12:47
@geoand
Copy link
Contributor

geoand commented Jun 15, 2022

Nice! I'll have a look hopefully tomorrow

geoand
geoand approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should probably mention this in the docs somewhere

@mkouba
Copy link
Contributor Author

mkouba commented Jun 17, 2022

LGTM.

We should probably mention this in the docs somewhere

This is just the first step. I do plan to mention this somewhere in the docs in one of the follow-up PR ;-).

@geoand
Copy link
Contributor

geoand commented Jun 17, 2022

👌

@mkouba mkouba force-pushed the build-metrics branch 2 times, most recently from ddf3f44 to 8014c88 Compare June 17, 2022 11:44
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Quarkus Builder - introduce build metrics
72ca803 
- dump the metrics to a JSON file in the build output:
  A. always in the dev mode
  B. when a system property is set: -Dquarkus.debug.dump-build-metrics=true
- add the list of the build steps to the Dev UI
- also add BuildStep#getId() and fix DOT graphviz generator (previously
ambiguous build step names were used)
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Jun 20, 2022

@gsmet ^ more flaky tests?

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2022

Failing Jobs - Building 72ca803

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment

📦 extensions/resteasy-reactive/rest-client-reactive-jaxb/deployment

✖ io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest.shouldConsumePlainXMLEntity - More details - Source on GitHub

org.jboss.resteasy.reactive.ClientWebApplicationException: Received: 'Internal Server Error, status code 500' when invoking: Rest Client method: 'io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest$XmlClient#plain'
	at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.unwrapException(RestClientRequestContext.java:170)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.handleException(AbstractResteasyReactiveContext.java:317)

✖ io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest.shouldConsumeXMLEntity - More details - Source on GitHub

org.jboss.resteasy.reactive.ClientWebApplicationException: Received: 'Internal Server Error, status code 500' when invoking: Rest Client method: 'io.quarkus.rest.client.reactive.jaxb.test.SimpleJaxbTest$XmlClient#dto'
	at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.unwrapException(RestClientRequestContext.java:170)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.handleException(AbstractResteasyReactiveContext.java:317)

@mkouba mkouba merged commit 5aac1c4 into quarkusio:main Jun 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 21, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 21, 2022
@mkouba mkouba mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

@dmlloyd dmlloyd Awaiting requested review from dmlloyd

Assignees
No one assigned
Labels
area/core area/vertx
Projects
None yet
Milestone
2.11.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @geoand @maxandersen