Fix Guide Rest Client Reactive Exception Handling

[felipewind]

I believe that:

• The implementation of ResponseExceptionMapper should be done by a class and not an interface.
• The method toThrowable should be public, or I receive this error: Cannot reduce the visibility of the inherited method from ResponseExceptionMapper<RuntimeException>

Current version

public interface MyResponseExceptionMapper implements ResponseExceptionMapper<RuntimeException> {

    RuntimeException toThrowable(Response response) {
        if (response.getStatus() == 500) {
            throw new RuntimeException("The remote service responded with HTTP 500");
        }
        return null;
    }
}

Proposed version

public class MyResponseExceptionMapper implements ResponseExceptionMapper<RuntimeException> {

    @Override
    public RuntimeException toThrowable(Response response) {
        if (response.getStatus() == 500) {
            throw new RuntimeException("The remote service responded with HTTP 500");
        }
        return null;
    }
}

[gastaldi]

@felipewind I think we're missing a default keyword in the interface method declaration?

Ah no, you're right, the doc states that an interface is implementing another interface, which is wrong (it should have been extends) but I'll let @michalszynkiewicz and @geoand review this ;)

[geoand]

Good catch!