Properly use headers set in Vert.x from RESTEasy Reactive #25323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Can I get a review of this please? Thanks |
gsmet
reviewed
May 5, 2022
.../server/runtime/src/main/java/org/jboss/resteasy/reactive/server/core/ServerSerialisers.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
@FroMage @stuartwdouglas can I get a review of this please? Thanks |
gastaldi
reviewed
May 17, 2022
.../server/runtime/src/main/java/org/jboss/resteasy/reactive/server/core/ServerSerialisers.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
gastaldi
approved these changes
May 18, 2022
This comment has been minimized.
This comment has been minimized.
Essentially this change makes sure RESTEasy Reactive does not override the values of the headers that were set from Vert.x Web Routes that ran before RESTEasy Reactive Fixes: quarkusio#25283
geoand
added
the
triage/waiting-for-ci
gastaldi
reviewed
May 18, 2022
.../server/runtime/src/main/java/org/jboss/resteasy/reactive/server/core/ServerSerialisers.java
Show resolved
Hide resolved
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially this change makes sure RESTEasy Reactive does not
override the values of the headers that were set from
Vert.x Web Routes that ran before RESTEasy Reactive
Fixes: #25283