Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - optimize CreationalContext for synthetic dependent beans #25129

Merged
merged 1 commit into from
Apr 25, 2022
Merged

ArC - optimize CreationalContext for synthetic dependent beans #25129

merged 1 commit into from
Apr 25, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 25, 2022

Follows up on #6432.

@mkouba
ArC - optimize CreationalContext for synthetic dependent beans
3592852 
- do store a synthetic dependent instance in CC if the bean has no
destruction logic
- related to quarkusio#25083
@mkouba mkouba requested a review from manovotn April 25, 2022 08:39
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Apr 25, 2022
@mkouba mkouba added this to the 2.9 - main milestone Apr 25, 2022
@mkouba mkouba mentioned this pull request Apr 25, 2022
Closed
manovotn
manovotn approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Apr 25, 2022

Both the errors seem to be unrelated docker-maven-plugin failures:

[ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.39.1:start (docker-start) on project quarkus-integration-test-hibernate-search-orm-elasticsearch: I/O Error: Unable to pull 'docker.elastic.co/elasticsearch

and

[ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.39.1:start (docker-start) on project quarkus-integration-test-hibernate-search-orm-opensearch: I/O Error: Unable to pull 'opensearchproject/opensearch:1.2.3'

Let's try to rerun the jobs...

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 25, 2022
@gsmet gsmet merged commit f6a0aec into quarkusio:main Apr 25, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.9.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @manovotn @gsmet