Support codestarts of extensions outside catalog #24949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/cli
This comment has been minimized.
This comment has been minimized.
aloubyansky
force-pushed
the
external-codestart
branch
from
e3aaef8 to
f97e032
Compare
|
Can the second commit be renamed to have a better description? Thanks |
|
Sure, I am testing the change. I think I'll need to adjust something more for the tests. |
This comment has been minimized.
This comment has been minimized.
aloubyansky
force-pushed
the
external-codestart
branch
from
f97e032 to
f5c5b3a
Compare
|
@ia3andy it's good now |
ia3andy
reviewed
Apr 20, 2022
There was a problem hiding this comment.
It's pretty cool, I was able to create a project with a standalone extension which has a codestart (without any trick).
mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create -Dextensions=org.acme:aloha-code:1.0.0-SNAPSHOT
We can potentially use old incompatible codestarts. At some point it might be good to introduce some kind of devtools/codestarts compatibility rules.
ia3andy
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21165
This change adds support for codestarts referenced from extensions that are not included in the registry catalogs.