Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta migration: more progress #24915

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Jakarta migration: more progress #24915

merged 2 commits into from
Apr 13, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 13, 2022

Also switch to a maintained version of subethasmtp that has a Jakarta impl.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2022

/cc @manovotn, @maxandersen, @radcortez, @Sanne

Sanne
Sanne reviewed Apr 13, 2022
View reviewed changes
build-parent/pom.xml
@@ -312,7 +312,7 @@
</dependency>

<dependency>
<groupId>org.subethamail</groupId>
<groupId>com.github.davidmoten</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a compromise? worth adding a note?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A compromise? No, it's a maintained fork of the original project which has been dead since forever (the last version was released 10 years ago).
I switch to it now so that the upgrade is easier as they provide both a version with javax and a version with jakarta and it's just a version bump once the upgrade is done.

Copy link
Member

@Sanne Sanne Apr 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. I guess I'm surprised we had a dependency to a long-dead project - and in such a core component.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it's a test dependency. Nevermind :)

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2022

Failing Jobs - Building c55cc92

Status Name Step Failures Logs Raw logs
✖ MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance

📦 tcks/microprofile-fault-tolerance

✖ org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@gsmet gsmet merged commit 04a67c8 into quarkusio:main Apr 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/jakarta area/kubernetes area/mailer area/persistence OBSOLETE, DO NOT USE area/smallrye area/testing area/tracing
Projects
None yet
Milestone
2.9.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@gsmet @Sanne