Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure test-extension artifacts are installed #24683

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Make sure test-extension artifacts are installed #24683

merged 1 commit into from
Apr 3, 2022

Conversation

famod
Copy link
Member

@famod famod commented Mar 31, 2022

Follows up on #24574. Required if building the tests module sibling individually.

Not entirely sure why it only happens sporadically, e.g. #24634 (comment)

@famod famod requested review from aloubyansky and gsmet March 31, 2022 21:28
@quarkus-bot

This comment has been minimized.

@famod
Copy link
Member Author

famod commented Mar 31, 2022

@radcortez I don't think UnknownBuildConfigTest should fail like that?

[INFO] Running io.quarkus.extest.UnknownBuildConfigTest
The output of the Quarkus build can be found at D:\a\quarkus\quarkus\integration-tests\test-extension\extension\deployment\target\quarkus-prod-mode-test4665286982218461875\build-result
2022-03-31 22:08:19,071 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final
2022-03-31 22:08:19,152 INFO  [io.qua.ext.dep.TestProcessor] (build-47) boot, launchMode=NORMAL
2022-03-31 22:08:19,250 WARN  [io.qua.dep.ste.BannerProcessor] (build-46) Unable to read banner file
2022-03-31 22:08:19,257 INFO  [io.qua.ext.dep.TestProcessor] (build-40) loadDSAPublicKey run
2022-03-31 22:08:19,678 INFO  [io.qua.ext.dep.TestProcessor] (build-21) Have XmlConfig, loading
2022-03-31 22:08:19,704 INFO  [io.qua.ext.dep.TestProcessor] (build-21) Loaded XmlConfig, creating service
2022-03-31 22:08:19,726 INFO  [io.qua.ext.dep.TestProcessor] (build-57) Registering service start
2022-03-31 22:08:19,903 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.build.unknown.prop" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,903 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.rename-old.only-in-new" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,903 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.unknown.prop" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,903 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.http.non.application.root.path" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,903 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.rename-old.only-in-old" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,904 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.http.ssl.port" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,904 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.rename-old.prop" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,904 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.rename-old.in-both" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,904 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.rename-old.with-default" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:19,904 WARN  [io.qua.config] (build-3) Unrecognized configuration key "quarkus.arc.unremovable-types[0]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
2022-03-31 22:08:20,937 INFO  [DSAPublicKeyObjectSubstitution] (build-61) DSAPublicKeyObjectSubstitution.serialize
2022-03-31 22:08:21,217 INFO  [io.qua.dep.QuarkusAugmentor] (main) Quarkus augmentation completed in 2730ms
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.301 s <<< FAILURE! - in io.quarkus.extest.UnknownBuildConfigTest
[ERROR] io.quarkus.extest.UnknownBuildConfigTest.unknownBuildConfig  Time elapsed: 0.002 s  <<< ERROR!
java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:221)
	at java.base/java.util.Arrays$ArrayList.<init>(Arrays.java:4323)
	at java.base/java.util.Arrays.asList(Arrays.java:4310)
	at io.quarkus.extest.UnknownBuildConfigTest.lambda$unknownBuildConfig$1(UnknownBuildConfigTest.java:32)

@radcortez
Copy link
Member

I think it may be related with: #24686.

There is a warning message in the logs:
2022-03-31 22:08:19,250 WARN [io.qua.dep.ste.BannerProcessor] (build-46) Unable to read banner file, which is probably causing the NPE in:

.filter(logRecord -> asList(**logRecord.getParameters()**).contains("quarkus.build.unknown.prop"))

We should guard the test against this.

@gsmet
Copy link
Member

gsmet commented Apr 1, 2022

FWIW I reverted the banner commit but it might come in in another form so better make the tests more solid.

@famod
Copy link
Member Author

famod commented Apr 1, 2022

so better make the tests more solid

I think that's something for a separate PR, so are we good to merge this one?

@famod famod merged commit e86b274 into quarkusio:main Apr 3, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 3, 2022
@famod famod deleted the fix-test-ext-install branch April 3, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants