-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure test-extension artifacts are installed #24683
Conversation
This comment has been minimized.
This comment has been minimized.
@radcortez I don't think
|
I think it may be related with: #24686. There is a warning message in the logs:
We should guard the test against this. |
FWIW I reverted the banner commit but it might come in in another form so better make the tests more solid. |
I think that's something for a separate PR, so are we good to merge this one? |
Follows up on #24574. Required if building the
tests
module sibling individually.Not entirely sure why it only happens sporadically, e.g. #24634 (comment)