Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Jakarta progress #24614

Merged
merged 4 commits into from
Mar 30, 2022
Merged

More Jakarta progress #24614

merged 4 commits into from
Mar 30, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 29, 2022

I was able to go up to RESTEasy Classic (just the server for now, I have a few things to fix for the client) and Hibernate Validator.

I also fixed a few other issues most notably the AnnotationProxyProvider.

Once we get this in, I'll trigger the rewrite job manually so that we can get the jakarta-rewrite branch updated. It might be handy if you want to build on top of it.

Also, you can do export REWRITE_NO_TESTS=true before running the script to avoid running the tests (which takes more time than necessary if you just want to check things build properly to make progress on other things)

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 29, 2022

/cc @manovotn, @maxandersen, @radcortez, @Sanne

Comment on lines +300 to +309
build_module_only_no_tests "extensions/resteasy-classic"
build_module "extensions/resteasy-classic/resteasy-common"
build_module "extensions/resteasy-classic/resteasy-server-common"
build_module "extensions/resteasy-classic/resteasy"
build_module "extensions/resteasy-classic/resteasy-jsonb"
build_module "extensions/resteasy-classic/resteasy-jackson"
build_module "extensions/resteasy-classic/resteasy-jaxb"
build_module "extensions/resteasy-classic/resteasy-links"
build_module "extensions/resteasy-classic/resteasy-mutiny-common"
build_module "extensions/resteasy-classic/resteasy-mutiny"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will simplify this once I can get the client part to work but for now it will do.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 30, 2022

Failing Jobs - Building c359f1b

Status Name Step Failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.UberJarQuarkusIntegrationTestIT.testUberJar line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.QuarkusITBase that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.UberJarQuarkusIntegrationTestIT.testUberJar line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.QuarkusITBase that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet
Copy link
Member Author

gsmet commented Mar 30, 2022

I'm merging that as we need to make progress on this and it's no big deal if it needs additional fixes.

@gsmet gsmet merged commit b82d849 into quarkusio:main Mar 30, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant