AWT, Native: Removes a workaround for loading iio-plugin.properties #24588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkak
approved these changes
Mar 29, 2022
|
@gsmet Would it be possible to have this eventually backported in 2.7 as per https://issues.redhat.com/browse/QUARKUS-1986 ? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iio-plugin.propertiesis correctly loaded from the JDK that is bundling the native-image toolchain, not from the one running the Maven build. Most importantly, if one runs the build using a builder image container, the properties file is loaded from the JDK bundled in the builder image.I tested that with a custom JDK build and a custom Mandrel build to have a garbled
iio-plugin.propertiesto compare.Why removing the workaround now: There likely hasn't been any reason for it to be there in the first place, I just didn't know any better :)