Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute test plan with the deployment classloader as the TCCL #24440

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

aloubyansky
Copy link
Member

Fix #24229

@aloubyansky
Copy link
Member Author

I should add a test though

@aloubyansky aloubyansky force-pushed the test-plan-deployment-cl branch from a0d8601 to d052ee2 Compare March 21, 2022 09:20
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, test would be nice.

Apart from that: LGTM; I tested it successfully in my real project and Stuart already said it's the proper way.
I'm only asking myself what's left for which we need the augmentation classloader (set in ModuleTestRunner)?

@famod
Copy link
Member

famod commented Mar 21, 2022

PS: IMO it makes sense to backport, but I'll leave this to you.

@gsmet
Copy link
Member

gsmet commented Mar 21, 2022

@aloubyansky do you plan on adding the test soon or should we merge?

@aloubyansky
Copy link
Member Author

Yes, I'll look into adapting the reproducer provided by @famod

@gsmet
Copy link
Member

gsmet commented Mar 22, 2022

@aloubyansky I will merge this tonight latest as I want this in CR1. If you don't have the time to write the test now, no biggie, we can include it later.

@aloubyansky
Copy link
Member Author

Unfortunately, I couldn't create a test case that would fail. I tried using ContinuousTestingTestUtils as a base utility but my test would still pass for 2.7.5.Final. Looks like we need a "cleaner" test framework for CT. Let's merge this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous testing is not picking up custom JUnit extension from same module
3 participants