-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Jandex Type parsing for array of primitive #24274
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Fix for #24228 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a small typo.
core/deployment/src/main/java/io/quarkus/deployment/util/AsmUtil.java
Outdated
Show resolved
Hide resolved
Commits squashed. |
core/deployment/src/main/java/io/quarkus/deployment/util/AsmUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if @FroMage has the time to check it it would be better as he understand the ASM part better than me.
Rebased and squashed. |
core/deployment/src/main/java/io/quarkus/deployment/util/AsmUtil.java
Outdated
Show resolved
Hide resolved
The change LGTM. I found that Jandex's |
Could you rebase and squash the commits? When you update from the main branch, please always use the rebase option. We don't want merge commits in the PRs. Thanks. |
Done |
core/deployment/src/test/java/io/quarkus/deployment/util/AsmUtilTest.java
Outdated
Show resolved
Hide resolved
Looks good to me, but can you squash your commits before we merge it? |
Sorry, I'm relative new to git and still learning how to use. |
Build failed due to timeout error |
Thanks! |
Thanks to all you guys to let me contribute! :) |
I wrote test only for broken code in core-deployment, not for Panache module where the error was found.
Just ran tests for code-deployment and test on reproducer project because I can't do a full build with tests due to QuarkusBindException.
Fix #24228