Change protocol name to TLS in QuarkusRestClientBuilder #24182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes
SSL
toTLS
; I haven't verified if in fact on Java 11SSL
still defaults toTLSv1.2
but even if does it is better to haveTLS
to avoid various scanners reporting false positives.I think having
TLS
is the most flexible option because (quoting some lines from Java Crypto docs):So if we explicitly start with
TLS1.2
then it may fail against the legacy servers which only implement TLS 1.0 or just don't correctly implement TLS version negotiation.With
TLS
Quarkus client will start withTLSv1.2
but will be able to drop toTLSv1.0
if necessary.Also CC @cescoffier