Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - fix evaluation for multiple matching namespace resolvers #24165

Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 8, 2022

- e.g. template extension methods for "config:"
- currently, the next part of an expression is completely ignored
@mkouba mkouba added this to the 2.8 - main milestone Mar 8, 2022
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Mar 8, 2022
@mkouba mkouba requested a review from gastaldi March 8, 2022 10:39
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 8, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 8, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building f9405c3

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

@gsmet
Copy link
Member

gsmet commented Mar 8, 2022

Please avoid restarting CI when something totally unrelated failed. Between multiple force pushes, rebases, and this, CI has been mostly overloaded today and didn't output anything useful.

If in doubt, ping me.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 8, 2022

Failing Jobs - Building f9405c3

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

@gsmet gsmet merged commit 109ec1d into quarkusio:main Mar 8, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 8, 2022
@gsmet
Copy link
Member

gsmet commented Mar 8, 2022

@glefloch these tests above are consistently failing today. This looks quite suspicious.

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.4.Final Mar 8, 2022
@mkouba
Copy link
Contributor Author

mkouba commented Mar 9, 2022

Please avoid restarting CI when something totally unrelated failed. Between multiple force pushes, rebases, and this, CI has been mostly overloaded today and didn't output anything useful.

If in doubt, ping me.

@gsmet Ok, I'm sorry for that. The problem is that one can never be sure if it's totally unrelated (esp. in case of arc and qute) and I don't want to bother you every time a similar failure occurs.

@gsmet
Copy link
Member

gsmet commented Mar 9, 2022

@mkouba in the end, it bothers me more if CI is overloaded and we can't merge anything. So don't hesitate :).

But we will also try to improve the CI stability. I see @glefloch added some logs to understand what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Qute] Custom default value is ignored in {config:boolean } rendering
3 participants