Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin to 1.6.20 #24086

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Update Kotlin to 1.6.20 #24086

merged 1 commit into from
Apr 5, 2022

Conversation

famod
Copy link
Member

@famod famod commented Mar 3, 2022

Draft mode until 1.6.20 is final.

I haven't done any specific tests myself, I only ran CI in my fork and locally I ran integration-tests/gradle with Java 11 and 18 EA.

/cc @evanchooly

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/gradle Gradle labels Mar 3, 2022
@famod famod marked this pull request as ready for review April 1, 2022 21:28
@famod famod requested a review from evanchooly April 1, 2022 21:29
@quarkus-bot

This comment has been minimized.

@gsmet gsmet mentioned this pull request Apr 4, 2022
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Apr 4, 2022
@gsmet
Copy link
Member

gsmet commented Apr 5, 2022

Rebased to fix a conflict.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 5, 2022
@gsmet gsmet merged commit 1088b9d into quarkusio:main Apr 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 5, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 5, 2022
@gsmet gsmet added release/noteworthy-feature triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 5, 2022
@MartinX3
Copy link

MartinX3 commented Apr 7, 2022

Could it get backported to 2.8?

@gsmet
Copy link
Member

gsmet commented Apr 7, 2022

@MartinX3 I don't know. Is it a bugfix only release on the Kotlin side or are there any potential breaking change?

@MartinX3
Copy link

MartinX3 commented Apr 7, 2022

It also adds new language features or puts them out of the experimental state if I read it correctly
https://blog.jetbrains.com/kotlin/2022/04/kotlin-1-6-20-released/

So i think it is not a bugfix only release
But I don't see breaking changes

@gsmet
Copy link
Member

gsmet commented Apr 7, 2022

I don't use Kotlin so I'm not really the right person to take an educated decision here. @evanchooly @geoand any opinion?

@geoand
Copy link
Contributor

geoand commented Apr 7, 2022

It seems to be bigger than usual, so I'd personally be in favor of not backporting

@famod famod deleted the kotlin-1.6.20 branch June 12, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/gradle Gradle release/noteworthy-feature triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants