Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift: Fix image pull policy property #24068

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Mar 3, 2022

The property quarkus.openshift.image-pull-policy was being ignored and the default value was IfNotPresent instead of Always.
This PR fixes both issues and covers these two scenarios (default setting ++ using he property to use an image pull policy).

Fix #23492

The property `quarkus.openshift.image-pull-policy` was being ignored and the default value was `IfNotPresent` instead of `Always`.
This PR fixes both issues and covers these two scenarios (default setting ++ using he property to use an image pull policy).

Fix quarkusio#23492
@Sgitario
Copy link
Contributor Author

Sgitario commented Mar 3, 2022

/cc @geoand @iocanel

@geoand
Copy link
Contributor

geoand commented Mar 7, 2022

@iocanel can you take a look at this fix?

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor

geoand commented Mar 8, 2022

Thanks!

@geoand geoand merged commit f526a8e into quarkusio:main Mar 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 8, 2022
@Sgitario Sgitario deleted the fix_ocp_imagepullpolicy branch March 8, 2022 09:13
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.4.Final Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated DeploymentConfig by OpenShift extension has wrong imagePullPolicy
4 participants