Verify OIDC WebClient works with the host verification #24063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Mar 3, 2022
|
@gsmet any reason why only a sub-part of the jobs has been executed? |
|
I assume that the GIB plugin (correctly) determined that no changes where made to no need run the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is very simple, it only confirms the host verification works, I could not get initially why it did not, but then I got it, the self-signed cert did not have a
CN=localhost, so I regenerated them.quarkus.oidc.tls.verification=certificate-validationleads toHttpClientOptions.setVerifyHost(false), so it is only used to verify the certificate is crypto sound,quarkus.oidc.tls.verification=requiredin addition keeps the defaultWebClientbehavior where the host verification is enforced by default.I'll follow up with another PR which will make
quarkus.oidc.tls.verification=requireda default option