Resteasy Reactive: Support use of optional with list/set/sortedset

[Sgitario]

Support use when using query params with some collections. Example:

@Path("/list")
    @GET
    public String sayHelloToList(@QueryParam("name") final Optional<List<String>> names) {
        return doSayHelloToCollection(names);
    }

fix #23898

[Sgitario]

/cc @geoand @Plawn

[Sgitario]

Moving to Draft as this is not fully working yet.

[geoand]

Thanks!

[Sgitario]

Moving to Draft as this is not fully working yet.

Now, the PR is ready to be reviewed.

There is a controversial difference of behaviors here between Resteasy Reactive and Resteasy Classic. Let's imagine we have the following endpoint:

@Path("/list")
@GET
public String sayHelloToList(@QueryParam("name") final Optional<List<String>> names) {
   // ...
}

If no query params are being set, I would expect to receive an optional empty. This is working like this in Resteasy Reactive, but in Resteasy Classic, you'll receive the optional with an empty list of strings.

[geoand]

Optional<List<T>> is always weird if you ask me...

I think the way we have it now is fine, I wouldn't worry too much about maintaining compatibility on this particular point

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 6e22f6e

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	Build	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 309 more

📦 extensions/resteasy-classic/resteasy/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-resteasy-deployment: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-classic/resteasy/deployment/src/test/java/io/quarkus/resteasy/test/QueryParamTest.java' has not been previously formatted. Please format file and commit before running validation!

[Plawn]

Is it really necessary to check if the collection is Empty ?

[Sgitario]

To return optional empty when the collection is empty, yes. See my comment here: #24055 (comment)

[Plawn]

Oh I see, you are right, It's better this way

[quarkus-bot]

Failing Jobs - Building 9dd7f7b

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-kafka 

📦 integration-tests/reactive-messaging-kafka

✖ io.quarkus.it.kafka.KafkaConnectorTest.testPets - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

[michalszynkiewicz]

Should we support Optional<List>, etc in the client too? Hmmm... maybe we already do

[Sgitario]

Should we support Optional<List>, etc in the client too? Hmmm... maybe we already do

As far I could see, the rest client reactive extension already supports it.