Update OIDC DefaultTokenStateManager to support the token encryption #23557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroigor
approved these changes
Feb 10, 2022
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcTenantConfig.java
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/DefaultTokenStateManager.java
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
oidc_encrypt_session_tokens
branch
from
7c296ee to
6a8ccb7
Compare
|
Hey Pedro @pedroigor This encKey is also now precalculated and its length checked similarly to the pkce key, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23373
This PR does a simple update to
DefaultTokenStateManagerto optionally encrypt the tokens before storing as the session cookie values and decrypt them if the encryption was requested. Update the tests, one of them now decrypts them, and the endpoint code also does a basic check that they contain 5 parts (=> JWE-encrypted), while the id/access/rt token injection still worksCC @debu999