Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also remove final from parent classes #23467

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

stuartwdouglas
Copy link
Member

Fixes #23282

@stuartwdouglas stuartwdouglas requested a review from mkouba February 7, 2022 00:26
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 7, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 52f73dd

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/elytron-undertow 

📦 integration-tests/elytron-undertow

io.quarkus.it.undertow.elytron.BaseAuthRestTest.testPost line 28 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 7, 2022
@gsmet gsmet merged commit d0119f6 into quarkusio:main Feb 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 7, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 7, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus @ApplicationScoped working in dev run, but not in prod
3 participants