Initialize defaultCatalog and defaultSchema in Hibernate ORM config

[gsmet]

No description provided.

[quarkus-bot]

Failing Jobs - Building 407910c

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 60 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in com.example.grpc.hibernate.BlockingRawTest that uses java.util.List was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

[yrodiere]

Sure, go ahead.

However:

1. If this is a problem, I'm surprised we don't have half of our testsuite failing with an NPE?
2. Shouldn't quarkus-config do this for us? It seems like a sane default.

[gsmet]

I know it's a problem because I had to do it for the others. Someone reported the NPE to me in private. I have no idea though why the test suite is not reporting the error.
The problem is not our config framework. We sometimes instantiate these objects ourselves when no config is defined (in the case of named persistence units).

[gsmet]

My guess is that it's probably because we always have generation defined to drop/create the schema.

As long as we have one config in this root, it's not a problem.

[yrodiere]

The problem is not our config framework. We sometimes instantiate these objects ourselves when no config is defined (in the case of named persistence units).

Maybe we should not call the constructor directly in this case, but ask quarkus-config (whatever it's named, the module that deserializes config) to instantiate an empty config? That way, defaults are set correctly, and we don't have to be so careful about what we do in this file.

I'll look into this when I have some time.