Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle: clear reloadable flag for extension dependencies #23412

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Gradle: clear reloadable flag for extension dependencies #23412

merged 1 commit into from
Feb 3, 2022

Conversation

aloubyansky
Copy link
Member

This has been missing in the Gradle plugin compared to the Maven one. Projects that include extensions could be failing w/o this fix due to project local dependencies ending up in different classloaders.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Feb 3, 2022
@aloubyansky aloubyansky requested a review from glefloch February 3, 2022 14:54
@aloubyansky
Copy link
Member Author

BTW, @glefloch working on this PR I noticed quite a few Gradle tests while passing are terminating with a time out. E.g.

[INFO] Running io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest
$ /home/aloubyansky/git/quarkus/integration-tests/gradle/./gradlew -D=maven.repo.local=/home/aloubyansky/.m2/repository --stacktrace clean quarkusDev -s
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.719 s - in io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest
[ERROR] System Exit has timed out in the forked process 1

With or without this specific PR. Have you noticed that?

glefloch
glefloch reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I haven't been able to reproduce it locally but sometimes, the Process started by java never ends, and we need to kill it.

@glefloch glefloch closed this Feb 3, 2022
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport? labels Feb 3, 2022
@glefloch glefloch reopened this Feb 3, 2022
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Feb 3, 2022
glefloch
glefloch approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I closed it by mistake. This looks good to me.

@glefloch glefloch merged commit 139a6e3 into quarkusio:main Feb 3, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 3, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Feb 3, 2022
@Foobartender Foobartender mentioned this pull request Feb 11, 2022
Closed
@Foobartender
Copy link
Contributor

This causes #23569 and probably #23591.

@geoand geoand mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glefloch glefloch glefloch approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Milestone
2.7.1.Final
Development

Successfully merging this pull request may close these issues.
5 participants
@aloubyansky @Foobartender @gastaldi @glefloch @gsmet