Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate gRPC code from dependencies #23374

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Generate gRPC code from dependencies #23374

merged 1 commit into from
Feb 3, 2022

Conversation

michalszynkiewicz
Copy link
Member

@michalszynkiewicz michalszynkiewicz commented Feb 2, 2022 •
edited
Loading

fixes #22603

michalszynkiewicz
michalszynkiewicz commented Feb 2, 2022
View reviewed changes
extensions/grpc/deployment/src/test/java/io/quarkus/grpc/server/devmode/GrpcDevModeTest.java
@@ -126,6 +128,28 @@ public void testProtoFileChangeReload() throws InterruptedException {
callHello("HACK_TO_GET_STATUS_NUMBER", "15");
}

@Test
public void testProtoFileChangeAndImplementationReload() throws InterruptedException {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aloubyansky this test checks if the compilation order is correct, that is #23271

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cescoffier
cescoffier previously requested changes Feb 2, 2022
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you update the documentation?

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 2, 2022 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9e3a3da

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 284 more

📦 extensions/resteasy-classic/resteasy/deployment

✖ io.quarkus.resteasy.test.IncompletePostTestCase.testIncompleteWrite line 36 - More details - Source on GitHub

java.net.ConnectException: Connection refused: connect
	at java.base/java.net.PlainSocketImpl.connect0(Native Method)
	at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:101)

@michalszynkiewicz michalszynkiewicz marked this pull request as draft February 3, 2022 14:17
@michalszynkiewicz
Copy link
Member Author

I found one issue with the new version, changed PR to draft until I fix it

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven labels Feb 3, 2022
@michalszynkiewicz
Copy link
Member Author

LGTM

Can you update the documentation?

done

@michalszynkiewicz michalszynkiewicz marked this pull request as ready for review February 3, 2022 14:55
@michalszynkiewicz
Copy link
Member Author

@cescoffier I let myself dismiss your review, if the docs are insufficient I'll fix it in another PR

@michalszynkiewicz michalszynkiewicz merged commit 23280af into quarkusio:main Feb 3, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 3, 2022
@michalszynkiewicz
Copy link
Member Author

It doesn't change any dependencies and it is a feature people were asking for on a few occasions. Maybe it could be backproted?

WDYT @aloubyansky @cescoffier @gsmet ?

@aloubyansky
Copy link
Member

Looks safe enough for backport to me.

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@mkouba mkouba Awaiting requested review from mkouba

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/grpc gRPC area/maven release/noteworthy-feature
Projects
None yet
Milestone
2.7.1.Final
Development

Successfully merging this pull request may close these issues.

gRPC code generation for specific dependencies
4 participants
@michalszynkiewicz @aloubyansky @cescoffier @gsmet