Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when the app is reading input #23298

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

stuartwdouglas
Copy link
Member

Fixes #23217

@stuartwdouglas
Copy link
Member Author

I think this is the best we can do, although it is not perfect. In particular:

  • For the non-basic console it will still be in raw mode, so input won't be echoed (and I don't seem to be able to exit raw mode)
  • You can force basic mode (quarkus.console.basic=true), or just disable the console altogether (quarkus.console.enabled=false)
  • This does not help the TextIO approach, as it reads directly from the file descriptor so there is nothing I can really do.

@geoand
Copy link
Contributor

geoand commented Jan 31, 2022

Should this backported to 2.7?

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 31, 2022

Failing Jobs - Building cd7bc3a

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.JandexMultiModuleProjectDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 281 more

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.IncompletePostTestCase.testIncompleteWrite line 36 - More details - Source on GitHub

java.net.ConnectException: Connection refused: connect
	at java.base/java.net.PlainSocketImpl.connect0(Native Method)
	at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:101)

@gsmet gsmet merged commit 933c4d4 into quarkusio:main Feb 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 7, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Feb 7, 2022
@PierreBtz
Copy link

Thanks for working on this, I can confirm it improves the situation in 2.7.1.Final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev mode captures console input destined to the application
4 participants