-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix openshift deployment related issues #23239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openshift-with-local-docker-and-deployment-resource.properties
seems to be empty, no?
I'll remove it! |
Looks good other than the empty file issue |
@iocanel could you fix this one? It looks like a simple one. |
@iocanel thanks! |
"Fallback to docker.io when using local builds on Openshift (align with container image extensions)." What does actually mean ? That relative image names is assumed to fetch from docker.io? |
The container image extension for docker/jib defaults to docker.io for pushing. The generated resources need to be aligned. |
Resolves: #23203
Resolves: #23417
The pull request addressed the following issues around openshift deployment:
Deploment
/StatefulSet