Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openshift deployment related issues #23239

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jan 27, 2022

Resolves: #23203
Resolves: #23417

The pull request addressed the following issues around openshift deployment:

  • Remove irrelevant warning about namespace/group mismatch on non-openshift builds: Irrelevant warning about mismatch between groups and projects  #23203
  • Generate missing streams when using local docker on Openshift.
  • Improve / Align logging between container image extension so that it's clear when the build is local or in-cluster.
  • Fallback to openshift internal registry when using in-cluster builds with Deploment / StatefulSet
  • Fallback to docker.io when using local builds on Openshift (align with container image extensions).

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift-with-local-docker-and-deployment-resource.properties seems to be empty, no?

@iocanel
Copy link
Contributor Author

iocanel commented Jan 28, 2022

I'll remove it!

@geoand
Copy link
Contributor

geoand commented Jan 31, 2022

Looks good other than the empty file issue

@gsmet
Copy link
Member

gsmet commented Feb 1, 2022

@iocanel could you fix this one? It looks like a simple one.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 1, 2022
@gsmet
Copy link
Member

gsmet commented Feb 1, 2022

@iocanel thanks!

@geoand geoand merged commit b4eaf7f into quarkusio:main Feb 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 1, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 1, 2022
@maxandersen
Copy link
Member

"Fallback to docker.io when using local builds on Openshift (align with container image extensions)." What does actually mean ?

That relative image names is assumed to fetch from docker.io?

@iocanel
Copy link
Contributor Author

iocanel commented Feb 2, 2022

"Fallback to docker.io when using local builds on Openshift (align with container image extensions)." What does actually mean ?

That relative image names is assumed to fetch from docker.io?

The container image extension for docker/jib defaults to docker.io for pushing. The generated resources need to be aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants