-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move HttpContentCompressorSubstitutions to quarkus-netty #23219
Conversation
ec111b4
to
839121d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I want to be sure it fixes the reported issue.
extensions/netty/runtime/src/main/java/io/quarkus/netty/runtime/graal/NettySubstitutions.java
Outdated
Show resolved
Hide resolved
extensions/netty/runtime/src/main/java/io/quarkus/netty/runtime/graal/NettySubstitutions.java
Outdated
Show resolved
Hide resolved
@gastaldi I made two minor comments. |
Something is odd...
|
@gastaldi so, it's not the proper fix. We already have the included substitutions. They are in the quarkus-vertx-http (Runtime) module. I can't remember why there are there... However, we need to copy it to the netty runtime module. |
Moved from vertx-http |
1bb11ab
to
92d8821
Compare
The commit message should be changed as it's pretty confusing now. |
Ah perfect, you just did it :). |
yeap, good catch |
Fixes #23218