Fail the building docker image when a Java version mismatch exists #23212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iocanel
approved these changes
Jan 26, 2022
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| interface DockerFileBaseInformationProvider { |
There was a problem hiding this comment.
I am wondering if this should be moved to spi or a commons module as we could possibly use it in other places too, e.g. container-image-openshift when we use the docker build strategy.
There was a problem hiding this comment.
I would say let's keep it here for now and if we do need it, then we can move. My point is that making it more general later is easier than making it part of an SPI now and potentially having to break down the line if this doesn't fit the bill for other use cases.
...main/java/io/quarkus/container/image/docker/deployment/RedHatOpenJDKRuntimeBaseProvider.java
Outdated
Show resolved
Hide resolved
This way users have an actionable error at build time instead of waiting to get the error when running the container
geoand
force-pushed
the
dockerfile-java17-warning
branch
from
e9fd603 to
769c605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users have an actionable error at build time instead
of waiting to get the error when running the container