Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to CLI's registry add command if no registry set #23207

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Add warning to CLI's registry add command if no registry set #23207

merged 1 commit into from
Jan 31, 2022

Conversation

ashwinair
Copy link
Contributor

Fixes #21905

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Jan 26, 2022
@ashwinair ashwinair changed the title add warning if no registry set Add warning if no registry set Jan 26, 2022
@geoand geoand requested a review from ebullient January 26, 2022 15:01
@geoand geoand changed the title Add warning if no registry set Add warning to CLI if no registry set Jan 26, 2022
@geoand geoand changed the title Add warning to CLI if no registry set Add warning to CLI's registry add command if no registry set Jan 26, 2022
ebullient
ebullient approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@ebullient ebullient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash into one commit, please.. but it LGTM. Thank you!

@ashwinair
Copy link
Contributor Author

Squash into one commit, please..

Done 👍

but it LGTM. Thank you!

Thnak you :)

@ebullient ebullient added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 28, 2022
@geoand geoand merged commit 0a0de3d into quarkusio:main Jan 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 31, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 31, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebullient ebullient ebullient approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
2.7.1.Final
Development

Successfully merging this pull request may close these issues.

Adding first registry in CLI erases the default one
4 participants
@ashwinair @ebullient @gsmet @geoand