Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker-compose up command to start services defined in docker-compose.yml file #23204

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

soul2zimate
Copy link
Contributor

…pose.yml file

https://docs.docker.com/compose/faq/#whats-the-difference-between-up-run-and-start

docker-compose up is supposed to be used to start or restart all the services defined in a docker-compose.yml.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but let's get Loïc's blessing.

@gsmet gsmet requested a review from loicmathieu January 26, 2022 09:31
@gsmet gsmet changed the title Use docker-compose up command to start services defined in docker-com… Use docker-compose up command to start services defined in docker-compose.yml file Jan 26, 2022
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch.

docker compose is supposed to be the replacement for docker-compose but it's not always available so let's keep it this way.

@gsmet gsmet merged commit 755349c into quarkusio:main Jan 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 26, 2022
@gsmet
Copy link
Member

gsmet commented Jan 26, 2022

Thanks!

@soul2zimate soul2zimate deleted the docker-compose-command branch January 27, 2022 01:34
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants