Add initializer method validation to ArC #23177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building b6e2896
Failures⚙️ Initial JDK 11 Build #- Failing: independent-projects/arc/tests
📦 independent-projects/arc/tests✖ |
mkouba
reviewed
Jan 25, 2022
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Injection.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Jan 25, 2022
Ladicek
force-pushed
the
arc-initializer-method-validation
branch
2 times, most recently
from
8794a9f to
67f250c
Compare
Ladicek
force-pushed
the
arc-initializer-method-validation
branch
from
67f250c to
124a552
Compare
mkouba
approved these changes
Jan 25, 2022
mkouba
added
the
triage/waiting-for-ci
|
I would like it to bake a bit before we consider backporting it. |
What do you mean "bake a bit"? This PR merely adds some validations that are required by the spec (and are tested by the TCK). No one should ever use this combination of annotations. That said, I don't mind if we postpone backporting after 2.7.0.Final 😉 |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23174
In addition to #23174, this PR also adds other validations the CDI specification prescribes for initializer methods (i.e., not just producers, but also disposers and observers).