-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete build-include-jdk-misc
from core/runtime
#22875
Conversation
@famod I'm not sure how removing this file changes anything the the version of the maven compiler plugin we use? The maven compiler plugin we need, yes, but the one we use? |
Check out the third link, there is a file-activated profile in jboss-parent. |
I can see that but I don't see it setting a version of the plugin? |
Right, there is some other magic involved. Need to check later. |
@gsmet that's why: jboss/jboss-parent-pom#112 But in latest released version 39 it's still there: https://github.com/jboss/jboss-parent-pom/blob/jboss-parent-39/pom.xml#L923 |
That Gradle issue looks unrelated, it passed in my fork: https://github.com/famod/quarkus/runs/4804350800?check_suite_focus=true#step:7:904 |
Ah ok cool, that's nice we switch to a standard version. |
Nice! that's one less problem when trying to import the project in IDEA. |
Yeah, or fighting overly "secure" artifactory caches. |
Failing Jobs - Building 648c3cf
Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/logging-gelf
📦 integration-tests/logging-gelf✖ |
JDK 17 failure is not related:
(and it passed in my fork) |
This avoids the usage of
maven-compiler-plugin
3.8.1-jboss-2, which seems obsolete at least as far CI in my fork is concerned.More context: