Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete build-include-jdk-misc from core/runtime #22875

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Remove obsolete build-include-jdk-misc from core/runtime #22875

merged 1 commit into from
Jan 13, 2022

Conversation

famod
Copy link
Member

@famod famod commented Jan 13, 2022

This avoids the usage of maven-compiler-plugin 3.8.1-jboss-2, which seems obsolete at least as far CI in my fork is concerned.

More context:

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2022
@gsmet
Copy link
Member

gsmet commented Jan 13, 2022

@famod I'm not sure how removing this file changes anything the the version of the maven compiler plugin we use? The maven compiler plugin we need, yes, but the one we use?

@famod
Copy link
Member Author

famod commented Jan 13, 2022

Check out the third link, there is a file-activated profile in jboss-parent.

@gsmet
Copy link
Member

gsmet commented Jan 13, 2022

I can see that but I don't see it setting a version of the plugin?

@famod
Copy link
Member Author

famod commented Jan 13, 2022

Right, there is some other magic involved. Need to check later.

@famod
Copy link
Member Author

famod commented Jan 13, 2022

@gsmet that's why: jboss/jboss-parent-pom#112
In that recent PR, @dmlloyd made the switch to the official plugin version.

But in latest released version 39 it's still there: https://github.com/jboss/jboss-parent-pom/blob/jboss-parent-39/pom.xml#L923

@famod
Copy link
Member Author

famod commented Jan 13, 2022

That Gradle issue looks unrelated, it passed in my fork: https://github.com/famod/quarkus/runs/4804350800?check_suite_focus=true#step:7:904

@gsmet
Copy link
Member

gsmet commented Jan 13, 2022

Ah ok cool, that's nice we switch to a standard version.

@Sanne
Copy link
Member

Sanne commented Jan 13, 2022

Nice! that's one less problem when trying to import the project in IDEA.

@famod
Copy link
Member Author

famod commented Jan 13, 2022

Yeah, or fighting overly "secure" artifactory caches.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2022

Failing Jobs - Building 648c3cf

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/logging-gelf 

📦 integration-tests/logging-gelf

Failed to execute goal io.fabric8:docker-maven-plugin:0.38.1:start (docker-start) on project quarkus-integration-test-logging-gelf: I/O Error

@famod
Copy link
Member Author

famod commented Jan 13, 2022

JDK 17 failure is not related:

Caused by: io.fabric8.maven.docker.access.hc.http.HttpRequestException: {"message":"Get \"https://docker.elastic.co/v2/\": dial tcp 34.68.230.202:443: connect: connection refused"} (Internal Server Error: 500)

(and it passed in my fork)

@famod famod merged commit 7273d6f into quarkusio:main Jan 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 13, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2022
@famod famod deleted the build-include-jdk-misc branch January 13, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants