Support for project modules that produce multiple JARs (with classifiers) #22336

aloubyansky · 2021-12-18T09:45:39Z

This change allows to have a "view" of an artifact content located at one or more output directories applying include and exclude filters. Essentially, it adds a possibility to support project modules that produce more than one (JAR) artifact.

Currently, the assumption in dev and test modes is that if an artifact resolves to one or more output directories, all the content found in those directories will represent the artifact's content. If however there were include/exclude filters configured for the artifact, this may lead to more classes/resources being indexed and loaded, which may lead to errors. This PR is an attempt to support these cases.

There are quite a few changes in the dependency-related API, for example:

ResolvedDependency.getResolvedPaths() now returns the paths that would have been resolved by Maven/Gradle (the current implementation prefers local output dirs in dev and test modes)
ResolvedDependency.getContentTree() returns an instance of PathTree representing artifact's content (whether it's a JAR or an output directory with possible filtering applied)
ArtifactSources WorkspaceModule.getSources(String classifier) allows to obtain the sources/output content layout for a given artifact (there are also helper methods like ArtifactSources getMainSources(), ArtifactSources getTestSources())
PathTreeClassPathElement was introduced and became the main impl of the ClassPathElement

@famod this should help your use-case, with this change your mocks classifier based on test-jar will be supported in dev mode. I would appreciate if you could give it a try and confirm it works for you. I did add a test in this PR for your use-case.

@Postremus do you mind checking this PR and perhaps see how far it throws back the performance gains you've achieved lately? :)

quarkus-bot · 2021-12-18T09:46:25Z

/cc @Karm, @galderz, @zakkak

aloubyansky · 2021-12-18T10:12:14Z

@glefloch this should allow us to better represent the Gradle model too, although it's not yet fully leveraged.

famod · 2021-12-18T10:34:45Z

Great, I'll put this high on my list!

quarkus-bot · 2021-12-18T14:29:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `646c0f3`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✖	Native Tests - HTTP	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/jdbc/jdbc-mssql/deployment 
! Skipped: integration-tests/jpa-mssql

📦 extensions/jdbc/jdbc-mssql/deployment

✖ io.quarkus.jdbc.mssql.deployment.DevServicesMsSQLDatasourceTestCase. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

⚙️ Native Tests - HTTP #

- Failing: integration-tests/vertx-http

📦 integration-tests/vertx-http

✖ io.quarkus.it.vertx.AccessLogTestCaseIT.testAccessLogContent - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined in public void io.quarkus.it.vertx.AccessLogTestCase.testAccessLogContent() throws java.lang.Exception access log doesn't contain an entry for /simple/access-log-test-endpoint?foo=fa037b01-102d-4a05-bab2-4849ed32c764 ==> expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

Postremus · 2021-12-18T18:23:15Z

@aloubyansky
Measurements as reported by the started in s. line.

mvn clean compile quarkus:dev
main (e866c8e): 2.028s
This PR (646c0f3): 2.782s

force restart (s)
main (e866c8e): 0.356s
This PR (646c0f3): 0.758s

aloubyansky · 2021-12-18T18:25:13Z

Wow. Thanks a lot @Postremus!

aloubyansky · 2021-12-18T18:43:51Z

@Postremus what did you use to profile bootstrapping? I am going to look into it.

Postremus · 2021-12-18T18:55:39Z

@aloubyansky
I used the reproducer from #21552 to retrieve the measurements.

For bootstrap profiling on windows, I use following approach:

Start the app using mvnw clean compile quarkus:dev -Dsuspend
Attach a profiler (e.g. in built async profiler from IDEA)
Connect a debugger to the app. This will let it continue running.
Wait till the app is started.
Stop the profiler.

On Linux / wslv2, I use async-profiler directly.

Add following configuration to quarkus-maven-plugin. Make sure to point to your async-profiler installation.

<configuration>
                    <jvmArgs>
                        -agentpath:/mnt/c/tools/java/async-profiler/build/libasyncProfiler.so=start,event=cpu,file=startup-cpu-profile-999-SNAPSHOT.html,interval=10000,simple
                    </jvmArgs>
                </configuration>

Start the app using mvnw clean compile quarkus:dev
Once the app is fully started, stop it.
In the main project directory, a .html file with the flamegraph should appear

aloubyansky · 2021-12-18T19:05:07Z

Thanks!

aloubyansky · 2021-12-20T13:30:15Z

Just fyi, I found how to get it to pretty much the same numbers as in 2.6.0.Final. I'll push an update once I clean my new changes up.

famod · 2021-12-21T11:40:33Z

@aloubyansky cool, I'll start testing once you have pushed that iteration.

aloubyansky · 2021-12-22T15:56:12Z

I pushed more changes with optimizations. Here is what I collected from 10 launches of mvn clean quarkus:dev and subsequent forced restarts for your reproducer project @Postremus on Linux:

2.6.0.Final
boot: 1412 ms
restart: 268 ms
main (175b973)
boot: 1355 ms
restart: 245 ms
this PR (6d572df)
boot: 1478 ms
restart: 229 ms

So the boot is still slower (especially compared to main - great job @Postremus), although not as dramatically. The restart was consistently faster by a bit, however.

aloubyansky · 2021-12-22T17:57:49Z

I'll need to fix this on Windows, probably a path handling issue

2021-12-22T16:26:37.5115433Z [ERROR] Failures: 
2021-12-22T16:26:37.5116613Z [ERROR]   OpenApiStaticModelsTestCase.testMultipleStaticFiles:33 1 expectation failed.
2021-12-22T16:26:37.5117923Z JSON path paths.'/openapi'.get.operationId doesn't match.
2021-12-22T16:26:37.5118749Z Expected: someOperation
2021-12-22T16:26:37.5119225Z   Actual: null

quarkus-bot · 2021-12-22T18:58:27Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `6d572df`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✖	Native Tests - HTTP	`Build`	Failures	Logs	Raw logs
✖	Native Tests - gRPC	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-openapi/deployment 
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 133 more

📦 extensions/smallrye-openapi/deployment

✖ io.quarkus.smallrye.openapi.test.jaxrs.OpenApiStaticModelsTestCase.testMultipleStaticFiles line 33 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path paths.'/openapi'.get.operationId doesn't match.

⚙️ Native Tests - HTTP #

- Failing: integration-tests/vertx-http

📦 integration-tests/vertx-http

✖ io.quarkus.it.vertx.AccessLogTestCaseIT.testAccessLogContent - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined in public void io.quarkus.it.vertx.AccessLogTestCase.testAccessLogContent() throws java.lang.Exception access log doesn't contain an entry for /simple/access-log-test-endpoint?foo=b547d99a-64ee-46c2-867c-f915b7abc539 ==> expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ Native Tests - gRPC #

- Failing: integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-mutiny

📦 integration-tests/grpc-mutual-auth

✖ io.quarkus.grpc.examples.hello.HelloWorldMutualTlsEndpointIT.testHelloWorldServiceUsingBlockingStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldMutualTlsEndpointIT.testHelloWorldServiceUsingMutinyStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldMutualTlsServiceIT.testHelloWorldServiceUsingBlockingStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldMutualTlsServiceIT.testHelloWorldServiceUsingMutinyStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

📦 integration-tests/grpc-plain-text-mutiny

✖ io.quarkus.grpc.examples.hello.HelloWorldEndpointIT.shouldSetHeader - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldEndpointIT.shouldSetHeaderWithMutiny - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldEndpointIT.shouldSetHeaderWithInterface - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldEndpointIT.testHelloWorldServiceUsingBlockingStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldEndpointIT.testHelloWorldServiceUsingMutinyStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldServiceIT.shouldSetHeader - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldServiceIT.shouldSetHeaderWithMutiny - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldServiceIT.shouldSetHeaderWithInterface - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldServiceIT.testHelloWorldServiceUsingBlockingStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

✖ io.quarkus.grpc.examples.hello.HelloWorldServiceIT.testHelloWorldServiceUsingMutinyStub - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

gsmet · 2021-12-22T19:54:08Z

I think we should get to the bottom of the slowdown because I fail to see how a change to support producing multiple jars could impact the default case.

aloubyansky · 2021-12-30T20:07:20Z

Looks like @stuartwdouglas is going to be on vacation until the 17th and might not have time to review this until the 2.7.0.CR1 (19.01), in which case it may be too late to include this in 2.7.0.Final (02.02).

famod · 2021-12-30T20:54:31Z

Bummer, but thanks for letting us know.
I hope you won't have too many merge conflicts over time.
I suppose nobody else can "replace" Stuart in this matter?

aloubyansky · 2021-12-30T21:46:38Z

I think this change fixes enough of critical issues (linked) to be considered for 2.7.0 even if Stuart isn't available. It has to get a proper review though. WDYT @gsmet and @geoand?

famod

I tried to be of some help and reviewed what I felt able to (and left some small comments).

LGTM overall, but I'm lacking in-depth knowledge of some parts!

famod · 2021-12-31T00:59:18Z

...ment/src/main/java/io/quarkus/vertx/http/deployment/devmode/console/DevConsoleProcessor.java

+        Files.walkFileTree(root, new SimpleFileVisitor<Path>() {
+            @Override
+            public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) throws IOException {
+                if (dir.equals(root) || dir.toString().equals("/") || dir.startsWith(devTemplatesPath))


Is this intentionally missing the curly brackets? This class seems a bit inconsistent in that regard, even before your changes.

I didn't pay attention, tbh. I'll add the brackets.

famod · 2021-12-31T01:02:10Z

...ojects/bootstrap/app-model/src/main/java/io/quarkus/bootstrap/workspace/WorkspaceModule.java


    PathCollection getBuildFiles();
+
+    default PathTree getContentTree(String classifier) {
+        //System.out.println("WorkspaceModule.getContentTree " + /* getId() + */ ":" + classifier);


This can probably be removed now?

Yes, I'll remove it, I kept it as a reminder this line could break dev mode.

famod · 2021-12-31T01:09:41Z

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/ArchivePathTree.java

+                    try {
+                        super.close();
+                    } finally {
+                        fs.close();


No idea how realistic either of the cases is here and maybe it was a deliberate choice, but if this fails it would shadow the exception from super.close() (if any).
Maybe add a catch and use addSuppressed()?

famod · 2021-12-31T01:11:05Z

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/DirectoryPathTree.java

+
+    @Override
+    public OpenPathTree openTree() {
+        return this;//CachingPathTree.of(this);


Is //CachingPathTree.of(this); a leftover?

It's kind of a WIP. I'll remove it.

famod · 2021-12-31T01:30:16Z

...endent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/PathTreeWithManifest.java

+            List<Integer> list = (List<Integer>) v.getClass().getMethod("version").invoke(v);
+            version = list.get(0);
+        } catch (Exception e) {
+            //version 8


Do we even support Java 8 anymore? pom.xml says no if I'm not mistaken.

We don't. I copied this code from another class, tbh. I'll change it to fail hard.

famod · 2021-12-31T01:33:20Z

...bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/AbstractClassPathElement.java

+            try {
+                return new Manifest(new ByteArrayInputStream(mf.getData()));
+            } catch (IOException e) {
+                log.warnf("Failed to parse manifest for %s", toString());


Is this intentionally swallowing the IOE?

I'll add e to the warnf.

famod · 2021-12-31T01:37:02Z

...bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/PathTreeClassPathElement.java

+    @Override
+    public Set<String> getProvidedResources() {
+        if (resources == null) {
+            synchronized (this) {


I'm probably missing something important or obvious, but shouldn't this use the locks instead?

Good point.

famod · 2021-12-31T01:38:17Z

...bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/PathTreeClassPathElement.java

+    @Override
+    protected Manifest readManifest() {
+        return withOpenTree(tree -> {
+            return tree.getManifest();


Could be a method ref instead, AFAICS.

famod · 2021-12-31T01:46:08Z

...maven-resolver/src/main/java/io/quarkus/bootstrap/resolver/maven/workspace/LocalProject.java

+                list.add(include.getValue());
+            }
+            filter = PathFilter.forIncludes(list);
+        } else {


Are you sure about ignoring excludes when there are includes?
E.g.: https://stackoverflow.com/a/2450803/9529981

No, I'll fix it.

Btw, this is a working link to that Scanner class: https://codehaus-plexus.github.io/plexus-utils/apidocs/org/codehaus/plexus/util/DirectoryScanner.html

Thanks, we'll need to add proper tests for this.

famod · 2021-12-31T01:51:56Z

independent-projects/bootstrap/app-model/src/main/java/io/quarkus/paths/PathTree.java

+
+            return new FilePathTree(p);
+        } catch (IOException e) {
+            throw new IllegalArgumentException(p + " does not exist");


This is probably the most likely case, but javadoc of Files.readAttributes says: if an I/O error occurs, so better include the IOE as the cause?

geoand · 2022-01-03T06:01:07Z

I think this change fixes enough of critical issues (linked) to be considered for 2.7.0 even if Stuart isn't available. It has to get a proper review though. WDYT @gsmet and @geoand?

I agree we want this in for 2.7

gsmet · 2022-01-03T19:50:26Z

@aloubyansky I was going to merge but unfortunately there is a conflict.

aloubyansky · 2022-01-03T19:51:39Z

Yes, rebased.

gsmet · 2022-01-03T19:57:21Z

OK, so let's merge this but it's big so let's be ready to fix things quickly after the CR1 release if things go south for some weird project setups.

quarkus-bot · 2022-01-04T03:28:18Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `db58b6b`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
⌛	Native Tests - Misc4	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/webjars-locator/deployment 
! Skipped: integration-tests/webjars-locator

📦 extensions/webjars-locator/deployment

✖ io.quarkus.webjar.locator.test.WebJarLocatorRootPathTest.test line 31 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/webjars-locator/deployment 
! Skipped: integration-tests/webjars-locator

📦 extensions/webjars-locator/deployment

✖ io.quarkus.webjar.locator.test.WebJarLocatorRootPathTest.test line 31 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/webjars-locator/deployment 
! Skipped: integration-tests/webjars-locator

📦 extensions/webjars-locator/deployment

✖ io.quarkus.webjar.locator.test.WebJarLocatorRootPathTest.test line 31 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

quarkus-bot · 2022-01-04T19:30:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `90b63db`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	Maven Tests - JDK 11	`Build`	Failures	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 290 more

📦 extensions/vertx-http/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project quarkus-vertx-http-deployment: There was a timeout in the fork

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 273 more

📦 extensions/resteasy-classic/resteasy/deployment

✖ io.quarkus.resteasy.test.files.StaticResourceDeletionBeforeFirstRequestTest.shouldReturn404HttpStatusCode line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <404> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 273 more

📦 extensions/resteasy-classic/resteasy/deployment

✖ io.quarkus.resteasy.test.files.StaticResourceDeletionBeforeFirstRequestTest.shouldReturn404HttpStatusCode line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <404> but was <500>.

⚙️ Maven Tests - JDK 11 #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNonExistentSrcDirCanBeAdded line 298 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.lang.String, java.lang.Stringint, intjava.util.concurrent.atomic.AtomicBoolean was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testThatNonExistentSrcDirCanBeAdded line 298 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.lang.String, java.lang.Stringint, intjava.util.concurrent.atomic.AtomicBoolean was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNonExistentSrcDirCanBeAdded line 298 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.lang.String, java.lang.Stringint, intjava.util.concurrent.atomic.AtomicBoolean was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testThatNonExistentSrcDirCanBeAdded line 298 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.lang.String, java.lang.Stringint, intjava.util.concurrent.atomic.AtomicBoolean was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

…ers)

…Tree

quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/graphics area/kotlin area/maven area/scala area/testing area/vertx labels Dec 18, 2021

aloubyansky requested review from stuartwdouglas, famod, Postremus and glefloch December 18, 2021 09:59

Postremus mentioned this pull request Dec 18, 2021

Make ZFS writeability configurable using env quarkusio/quarkus-fs-util#6

Closed

aloubyansky force-pushed the multijar-modules branch from 646c0f3 to 6d572df Compare December 22, 2021 15:08

famod mentioned this pull request Dec 29, 2021

Recalculate the local artifacts for continuous testing to take into account test-scoped dependencies #22551

Closed

famod approved these changes Dec 31, 2021

View reviewed changes

aloubyansky force-pushed the multijar-modules branch from f0aa871 to c0dc00f Compare January 1, 2022 21:56

aloubyansky force-pushed the multijar-modules branch from c0dc00f to 8e83b6c Compare January 3, 2022 14:05

aloubyansky force-pushed the multijar-modules branch from 8e83b6c to 0f37bb0 Compare January 3, 2022 19:51

aloubyansky force-pushed the multijar-modules branch 2 times, most recently from 7856f6a to db58b6b Compare January 3, 2022 23:04

aloubyansky force-pushed the multijar-modules branch 3 times, most recently from 588faf2 to 90b63db Compare January 4, 2022 17:30

aloubyansky and others added 2 commits January 4, 2022 21:47

Support for project modules that produce multiple JARs (with classifi…

aca373e

…ers)

Only read file attributes once when creating Directory or ArchivePath…

8bb2afd

…Tree

aloubyansky force-pushed the multijar-modules branch from 90b63db to 8bb2afd Compare January 4, 2022 20:48

Postremus approved these changes Jan 4, 2022

View reviewed changes

aloubyansky merged commit 1b4116f into quarkusio:main Jan 5, 2022

quarkus-bot bot added this to the 2.7 - main milestone Jan 5, 2022

This was referenced Jan 5, 2022

Introduce support for Uni return types in Micrometer annotations #22639

Merged

Revert "Support for project modules that produce multiple JARs (with classifiers)" #22646

Merged

aloubyansky mentioned this pull request Jan 5, 2022

Support for project modules that produce multiple JARs (with classifiers) #22673

Merged

famod mentioned this pull request Dec 15, 2023

Core: make it possible to index dependencies with a specific groupId #37739

Merged

famod mentioned this pull request Aug 15, 2024

application-test.properties leaks into downstream module tests even though only application.properties is included in the test-jar #42580

Closed

Support for project modules that produce multiple JARs (with classifiers) #22336

Support for project modules that produce multiple JARs (with classifiers) #22336

Conversation

aloubyansky commented Dec 18, 2021 • edited Loading

quarkus-bot bot commented Dec 18, 2021

aloubyansky commented Dec 18, 2021

famod commented Dec 18, 2021

quarkus-bot bot commented Dec 18, 2021 • edited Loading

Failing Jobs - Building 646c0f3

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mssql/deployment

⚙️ Native Tests - HTTP #

📦 integration-tests/vertx-http

Postremus commented Dec 18, 2021

aloubyansky commented Dec 18, 2021

aloubyansky commented Dec 18, 2021

Postremus commented Dec 18, 2021 • edited Loading

aloubyansky commented Dec 18, 2021

aloubyansky commented Dec 20, 2021

famod commented Dec 21, 2021

aloubyansky commented Dec 22, 2021 • edited Loading

aloubyansky commented Dec 22, 2021

quarkus-bot bot commented Dec 22, 2021 • edited Loading

Failing Jobs - Building 6d572df

Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/smallrye-openapi/deployment

⚙️ Native Tests - HTTP #

📦 integration-tests/vertx-http

⚙️ Native Tests - gRPC #

📦 integration-tests/grpc-mutual-auth

📦 integration-tests/grpc-plain-text-mutiny

gsmet commented Dec 22, 2021

aloubyansky commented Dec 30, 2021

famod commented Dec 30, 2021

aloubyansky commented Dec 30, 2021

famod left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

famod Dec 31, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geoand commented Jan 3, 2022

gsmet commented Jan 3, 2022

aloubyansky commented Jan 3, 2022

gsmet commented Jan 3, 2022

quarkus-bot bot commented Jan 4, 2022 • edited Loading

Failing Jobs - Building db58b6b

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/webjars-locator/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/webjars-locator/deployment

⚙️ JVM Tests - JDK 17 #

📦 extensions/webjars-locator/deployment

quarkus-bot bot commented Jan 4, 2022 • edited Loading

Failing Jobs - Building 90b63db

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

⚙️ JVM Tests - JDK 11 Windows #

aloubyansky commented Dec 18, 2021 •

edited

Loading

quarkus-bot bot commented Dec 18, 2021 •

edited

Loading

Failing Jobs - Building `646c0f3`

Postremus commented Dec 18, 2021 •

edited

Loading

aloubyansky commented Dec 22, 2021 •

edited

Loading

quarkus-bot bot commented Dec 22, 2021 •

edited

Loading

Failing Jobs - Building `6d572df`

famod left a comment •

edited

Loading

famod Dec 31, 2021 •

edited

Loading

quarkus-bot bot commented Jan 4, 2022 •

edited

Loading

Failing Jobs - Building `db58b6b`

quarkus-bot bot commented Jan 4, 2022 •

edited

Loading

Failing Jobs - Building `90b63db`