-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Keycloak DevService work with @QuarkusIntegrationTest and container launches #21999
Conversation
.../main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java
Show resolved
Hide resolved
.../main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java
Show resolved
Hide resolved
.../main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java
Show resolved
Hide resolved
...mework/keycloak-server/src/main/java/io/quarkus/test/keycloak/client/KeycloakTestClient.java
Show resolved
Hide resolved
Thanks @geoand for the time, it looks good. I've left a few minor comments. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 248df46
Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/hibernate-reactive-db2 integration-tests/jpa-db2
📦 integration-tests/hibernate-reactive-db2✖ 📦 integration-tests/jpa-db2✖ |
You are welcome!
I already did that when testing the PR :). I ran all the tests and also used the DevUI to test |
Nice, thanks :-) |
👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
I propose to wait till tomorrow for Stuart to have a quick look at the TCCL related update, I'll merge the first thing tomorrow morning if there will be no comments...
…ner launches Fixes: quarkusio#21995
Let's also wait for the 👍 from @gsmet who is in the process of moving extensions, so we don't want to make his life harder |
@stuartwdouglas if you're good with this one, please merge it. I will start the release tomorrow morning early Paris time. |
@stuartwdouglas could you take a look please? |
Since this is something that would be good to have in for |
Fixes: #21935
Supercedes: #21995
P.S. The integration test was copied almost verbatim from the reproducer added in #21935