Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Keycloak DevService work with @QuarkusIntegrationTest and container launches #21999

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 7, 2021

Fixes: #21935

Supercedes: #21995

P.S. The integration test was copied almost verbatim from the reproducer added in #21935

@sberyozkin
Copy link
Member

Thanks @geoand for the time, it looks good. I've left a few minor comments.
Also, if you don't mind, can you please run quarkus-quickstarts/security-openid-connect-quickstart which tests it without the shared network, might also be worth checking if you can login into Keycloak after mvn quarkus-dev and then selecting Keycloak from Dev UI console (as alice:alice for example), https://quarkus.io/guides/security-openid-connect-dev-services#dev-services-for-keycloak (click on that green Login into SPA and you'll be redirected to Keycloak)...

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 248df46

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/hibernate-reactive-db2 integration-tests/jpa-db2 

📦 integration-tests/hibernate-reactive-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.38.0:start (docker-start) on project quarkus-integration-test-hibernate-reactive-db2: I/O Error

📦 integration-tests/jpa-db2

Failed to execute goal io.fabric8:docker-maven-plugin:0.38.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error

@geoand
Copy link
Contributor Author

geoand commented Dec 7, 2021

Thanks @geoand

You are welcome!

Also, if you don't mind, can you please run quarkus-quickstarts/security-openid-connect-quickstart

I already did that when testing the PR :). I ran all the tests and also used the DevUI to test alice and admin

@sberyozkin
Copy link
Member

Nice, thanks :-)

@geoand
Copy link
Contributor Author

geoand commented Dec 7, 2021

👍🏼

@geoand geoand requested a review from sberyozkin December 7, 2021 17:37
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I propose to wait till tomorrow for Stuart to have a quick look at the TCCL related update, I'll merge the first thing tomorrow morning if there will be no comments...

@geoand
Copy link
Contributor Author

geoand commented Dec 7, 2021

Let's also wait for the 👍 from @gsmet who is in the process of moving extensions, so we don't want to make his life harder

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2021

Failing Jobs - Building db518c3

Status Name Step Failures Logs Raw logs
Native Tests - Data2 Download Maven Repo ⚠️ Check → Logs Raw logs

@gsmet
Copy link
Member

gsmet commented Dec 7, 2021

@stuartwdouglas if you're good with this one, please merge it. I will start the release tomorrow morning early Paris time.

@geoand
Copy link
Contributor Author

geoand commented Dec 8, 2021

@stuartwdouglas could you take a look please?
It would be nice to get this in 2.6.0.CR1

@geoand
Copy link
Contributor Author

geoand commented Dec 8, 2021

Since this is something that would be good to have in for 2.6.0.CR1 to validate the approach and ensure that no new issues will creep up, I'm going to merge it now.
We can certainly improve on the specifics easily, but the various fixes themselves are necessary for a better @QuarkusIntegrationTest + Keycloak DevServices experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak DevService not considered healthy when running in docker shared network mode
3 participants