Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure quarkusGenerateCode is run before tests #21910

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Make sure quarkusGenerateCode is run before tests #21910

merged 1 commit into from
Dec 3, 2021

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Dec 3, 2021

If we only ask for the test task, we are only running the quarkusGenerateCodeTests task but not the quarkusGenerateCode which generate code for the main sourceSet.
This adds a dependency between quarkusGenerateCode task and the test task.

close #21878

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Dec 3, 2021
@glefloch glefloch merged commit 249d155 into quarkusio:main Dec 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Dec 3, 2021
@glefloch glefloch deleted the fix/21878 branch December 3, 2021 12:48
@gsmet gsmet modified the milestones: 2.6.0.CR1, 2.5.2.Final Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi Awaiting requested review from gastaldi

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Milestone
2.5.2.Final
Development

Successfully merging this pull request may close these issues.

GRPC: Does not generate proto-based files
3 participants
@glefloch @aloubyansky @gsmet