-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests with coverage docs with Gradle examples #21896
Conversation
I think this needs some more work on my end. Thought I had it working, but maybe not yet... Still seeing some issues when running a combination of plain unit tests and tests with |
I'm struggling to get the coverage verification to be aligned with the combination of plain unit tests and Probably related to #18726 |
Perhaps the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @brianwyka. The overall looks good to me. I left some comments about titles and applying the jacoco
plugin
Thanks for the review @glefloch . I'll make the changes. However, I think the section on the verification is still inaccurate since it does not work correctly at the moment. Is there any idea there? |
I believe I found a workaround to the issue (reported on Gradle): Is it okay to document this workaround until its fixed on Gradle side? |
If it's working, I think we can with a reference to the issue |
@glefloch , updated docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left few comments. Should be good after that.
Should be all set now @glefloch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brianwyka
I force pushed a rebase + squash. Will merge as soon as CI is green. |
Thanks @gsmet and @brianwyka ! |
Reference: https://docs.gradle.org/7.3/userguide/jacoco_plugin.html