Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export module sun.security.action for DB2 jdbc driver #21886

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Dec 2, 2021

com.ibm.db2:jcc:11.5.6.0 accesses sun.security.action.GetPropertyAction which is strongly encapsulated in Java 17 requiring
--add-exports=java.base/sun.security.action=ALL-UNNAMED

com.ibm.db2:jcc:11.5.6.0 accesses sun.security.action.GetPropertyAction
which is strongly encapsulated in Java 17 requiring
--add-exports=java.base/sun.security.action=ALL-UNNAMED
@quarkus-bot quarkus-bot bot added the area/persistence OBSOLETE, DO NOT USE label Dec 2, 2021
@zakkak zakkak requested a review from gsmet December 2, 2021 12:56
@zakkak zakkak added env/graalvm-java17 Relating to using GraalVM native generation Java 11 area/native-image labels Dec 2, 2021
@gastaldi gastaldi merged commit e2482f4 into quarkusio:main Dec 2, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Dec 2, 2021
@@ -77,4 +78,12 @@ void registerServiceBinding(Capabilities capabilities,
}
dbKind.produce(new DefaultDataSourceDbKindBuildItem(DatabaseKind.DB2));
}

@BuildStep
void addBouncyCastleExportsToNativeImage(BuildProducer<JPMSExportBuildItem> jpmsExports) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was merged a bit too fast, I don't think the method name is what you wanted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, indeed... copy paste... I'll open a new one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed it, my bad...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak zakkak deleted the fix-db2-jdbc-java17 branch December 2, 2021 19:54
zakkak added a commit to zakkak/quarkus that referenced this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/native-image area/persistence OBSOLETE, DO NOT USE env/graalvm-java17 Relating to using GraalVM native generation Java 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants