Polish LambdaHttpHandler instances #21734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came about while trying to reproduce the problem mentioned in quarkusio#21559
gsmet
approved these changes
Nov 26, 2021
| @@ -46,7 +46,7 @@ | |||
|
|
|||
| private static final int BUFFER_SIZE = 8096; | |||
|
|
|||
| private static Headers errorHeaders = new Headers(); | |||
| private static final Headers errorHeaders = new Headers(); | |||
There was a problem hiding this comment.
I think code checkers will complain about the case as it's a constant (same for the other file).
There was a problem hiding this comment.
I don't get it, what would they complain about?
There was a problem hiding this comment.
Case for constants should be LIKE_THIS.
There was a problem hiding this comment.
Ah, the case. You mentioned it, but it just didn't register..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about while trying to reproduce the
problem mentioned in #21559