Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - make the set of escaped content-types configurable #21732

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 26, 2021

- introduce the quarkus.qute.escape-content-types configuration property
- resolves quarkusio#21731
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 26, 2021

Failing Jobs - Building af991ad

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 29, 2021
@famod
Copy link
Member

famod commented Nov 29, 2021

@mkouba should.xhtml be a part of the suffixes default value, given that application/xhtml+xml is now a part of the content-types default value?

@mkouba
Copy link
Contributor Author

mkouba commented Nov 29, 2021

@mkouba should.xhtml be a part of the suffixes default value, given that application/xhtml+xml is now a part of the content-types default value?

Hmm, IDK. .xhtml is probably not so commonly used these days and I'd like to keep this list short and concise. On the other hand, it would not harm anything. At runtime the list is only used to locate a template if no suffix is used, e.g. if you attempt to locate a template foo then we try foo.txt etc. as well. If we add .xhtml then we should also add .xml and .qute.xhtml and .qute.xml... which is -0.5 from me.

@famod
Copy link
Member

famod commented Nov 29, 2021

Alright! I'll merge this as that tck failure is not related.

@famod famod merged commit d510635 into quarkusio:main Nov 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 29, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute should allow configuring HTML escaping for "custom" content-types/variants
3 participants