Don't include version in the Swagger UI header #21686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing good comes from exposing this information by default.
phillip-kruger
approved these changes
Nov 25, 2021
|
We might need the same for health and graphql, I'll have a look |
|
Also dev ui? Even though that is just in dev, the idea is to make moving from dev ui to swagger and others look the same. Or, we need to change that we show it in dev mode, but not in other modes ? |
|
Dev UI is fine IMHO, we just don't want this for things that can be included in the production app to include the version. |
geoand
approved these changes
Nov 25, 2021
|
Ok, maybe I can then make a change to Dev UI to show it somewhere else ? Then the look are still the same if you do from Dev UI to Swagger UI ? |
|
I don't think it's a problem to have slightly different information for Dev UI. |
|
ok cool :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing good comes from exposing this information by default.