Fix Reactive Route stream serialization without relying on the Multi sub-type #21643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This a breaking change, right? Because previously, the |
|
Yes, it is breaking if you were configuring ‘produces.’ However, in practice, it should not happen too much (still needs to be mentioned. |
mkouba
reviewed
Nov 24, 2021
...routes/deployment/src/main/java/io/quarkus/vertx/web/deployment/ReactiveRoutesProcessor.java
Outdated
Show resolved
Hide resolved
extensions/reactive-routes/runtime/src/main/java/io/quarkus/vertx/web/ReactiveRoutes.java
Outdated
Show resolved
Hide resolved
…not require a specific Multi sub-type. Sub-typing Multi does not work when the route is protected using @RolesAllowed as the security interceptor changes the returned Multi actual type. The previous approach is still supported but is deprecated. The documentation mentions the new approach and explains why the previous approach should be avoided.
cescoffier
force-pushed
the
reactive-routes-multi-serialization
branch
from
cda9429 to
6949c56
Compare
mkouba
approved these changes
Nov 25, 2021
|
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items.
|
|
@cescoffier Pls add a note to the migration guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide another way to generate streams from Reactive Routes that do not require a specific Multi sub-type.
Sub-typing Multi does not work when the route is protected using @RolesAllowed as the security interceptor changes the returned Multi actual type.
The previous approach is still supported but is deprecated. The documentation mentions the new approach and explains why the previous approach should be avoided.
CC @michalszynkiewicz
Fix #21044